Emulation/Gopher2600
1
0
Fork 0
mirror of https://github.com/JetSetIlly/Gopher2600.git synced 2024-06-02 20:18:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

nilness check for BorrowSource() was done too early

Browse source 
completes changes done in ee1656fc8
This commit is contained in:
JetSetIlly 2024-03-05 15:57:51 +00:00
parent d9e0bd0380
commit 5bc7cb809b
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
gui/sdlimgui/win_cart_static.go
View file

@ -142,9 +142,10 @@ func (win *winCartStatic) draw(static mapper.CartStatic) {
if ok {
win.img.dbg.CoProcDev.BorrowSource(func(src *dwarf.Source) {
if src == nil {
return
}
// the borrowed source instance is used in the after()
// function to help decorate the memory cells in the table.
// a check for nil is done then
compData, ok := compStatic.Reference(seg.Name)
if ok {
// take copy of seg.Name because we'll be accessing it in a PushFunction() below
@ -172,6 +173,12 @@ func (win *winCartStatic) draw(static mapper.CartStatic) {
imgui.PopStyleColorV(popColor)
popColor = 0
// if no source is available then there is nothing
// more to do in the after() function
if src == nil {
return
}
// idx is based on original values of type uint16 so the type conversion is safe
addr := seg.Origin + uint32(idx)