Emulation/Gopher2600
1
0
Fork 0
mirror of https://github.com/JetSetIlly/Gopher2600.git synced 2024-05-20 05:40:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

removed prefs update ticker from ARM

Browse source 
it's not necessary for performance and worse, it causes memory churn due
to how the gui caching package works
This commit is contained in:
JetSetIlly 2024-05-02 22:03:24 +01:00
parent 545caefbfa
commit 8e4838d582
1 changed files with 6 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
hardware/memory/cartridge/arm/arm.go
View file

@ -20,7 +20,6 @@ import (
"fmt"
"math"
"strings"
"time"
"github.com/jetsetilly/gopher2600/coprocessor"
"github.com/jetsetilly/gopher2600/coprocessor/developer/faults"
@ -214,12 +213,7 @@ type ARM struct {
// state of the ARM. saveable and restorable
state *ARMState
// updating the preferences every time run() is executed can be slow
// (because the preferences need to be synchronised between tasks). the
// prefsPulse ticker slows the rate at which updatePrefs() is called
prefsPulse *time.Ticker
// read from ARM.prefs every prefsPulse tick
// updated on every call to run()
abortOnMemoryFault bool
misalignedAccessIsFault bool
@ -261,7 +255,8 @@ type ARM struct {
// interface to an option development package
dev coprocessor.CartCoProcDeveloper
// whether cycle count or not. set from ARM.prefs at the start of every arm.Run()
// immediateMode controls whether cycle count or not. value updated from
// updatePrefs()
//
// used to cut out code that is required only for cycle counting. See
// Icycle, Scycle and Ncycle fields which are called so frequently we
@ -294,12 +289,7 @@ func NewARM(env *environment.Environment, mmap architecture.Map, mem SharedMemor
hook: hook,
byteOrder: binary.LittleEndian,
executionCache: make(map[uint32][]decodeFunction),
// updated on every updatePrefs(). these are reasonable defaults
Clk: 70.0,
clklenFlash: 4.0,
state: &ARMState{},
state: &ARMState{},
}
// disassembly printed to stdout
@ -307,9 +297,6 @@ func NewARM(env *environment.Environment, mmap architecture.Map, mem SharedMemor
arm.disasm = &coprocessor.CartCoProcDisassemblerStdout{}
}
// slow prefs update by 100ms
arm.prefsPulse = time.NewTicker(time.Millisecond * 100)
switch arm.mmap.ARMArchitecture {
case architecture.ARM7TDMI:
arm.stepFunction = arm.stepARM7TDMI
@ -436,8 +423,7 @@ func (arm *ARM) resetRegisters() {
}
// updatePrefs should be called periodically to ensure that the current
// preference values are being used in the ARM emulation. see also the
// prefsPulse ticker
// preference values are being used in the ARM emulation
func (arm *ARM) updatePrefs() {
// update clock value from preferences
arm.Clk = float32(arm.env.Prefs.ARM.Clock.Get().(float64))
@ -756,11 +742,7 @@ func (arm *ARM) checkProgramMemory(force bool) {
}
func (arm *ARM) run() (coprocessor.CoProcYield, float32) {
select {
case <-arm.prefsPulse.C:
arm.updatePrefs()
default:
}
arm.updatePrefs()
// number of iterations. only used when in immediate mode
var iterations int