Emulation/mupen64plus-video-z64
1
0
Fork 0
mirror of https://github.com/mupen64plus/mupen64plus-video-z64.git synced 2024-05-18 12:00:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

add function attributes so GCC can find bugs in calls to string formatting functions with variadic arguments

Browse source
This commit is contained in:
Richard Goedeken 2019-03-03 11:02:59 -08:00
parent d74eb05ccf
commit 49d5594bd2
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/rdp.h
View file

@ -22,6 +22,12 @@
#ifndef _RDP_H_
#define _RDP_H_
#if defined(__GNUC__)
#define ATTR_FMT(fmtpos, attrpos) __attribute__ ((format (printf, fmtpos, attrpos)))
#else
#define ATTR_FMT(fmtpos, attrpos)
#endif
#include <stdint.h>
#include <stdio.h>
#include <stdlib.h>
@ -247,7 +253,7 @@ int rdp_dasm(uint32_t * rdp_cmd_data, int rdp_cmd_cur, int length, char *buffer)
void rdp_process_list(void);
int rdp_store_list(void);
void rdp_log(m64p_msg_level level, const char *msg, ...);
void rdp_log(m64p_msg_level level, const char *msg, ...) ATTR_FMT(2,3);
#ifdef RDP_DEBUG
@ -258,7 +264,9 @@ extern int rdp_dump;
#define DUMP if (!rdp_dump) ; else LOG
static void LOG(const char * s, ...)
static void LOG(const char * s, ...) ATTR_FMT(1,2);
void LOG(const char * s, ...)
{
va_list ap;
va_start(ap, s);

8
src/rgl_debugger.cpp
View file

@ -24,6 +24,12 @@
#include "rdp.h"
#include "rgl.h"
#if defined(__GNUC__)
#define ATTR_FMT(fmtpos, attrpos) __attribute__ ((format (printf, fmtpos, attrpos)))
#else
#define ATTR_FMT(fmtpos, attrpos)
#endif
static const char *saRGBText[] =
{
"PREV", "TEXEL0", "TEXEL1", "PRIM",
@ -176,7 +182,7 @@ void gglPrint(int x, int y, const char * text)
//printf("%s\n", text);
}
void gglPrintf(int x, int y, const char * s, ...)
void gglPrintf(int x, int y, const char * s, ...) ATTR_FMT(3,4)
{
char buf[1024];
va_list ap;